Fix/otp attempts verification #1466
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…default client IP to 'unknown' in UsersService
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
dcshzj
reviewed
Dec 4, 2025
src/routes/v2/auth.js
Outdated
| }) | ||
| const email = rawEmail.toLowerCase() | ||
| const userInfo = (await this.authService.verifyOtp({ email, otp })).value | ||
| const userIp = isSecure ? req.get("cf-connecting-ip") : req.ip |
Contributor
There was a problem hiding this comment.
nit: this line is making an assumption about Cloudflare's existence which we know may not necessarily be true. Noting this down as a nit for us to follow up as a separate fix as part of the Cloudflare post-mortem action items.
FYI will extract this out into a common function and add a comment there for follow-up.
Comment on lines
+236
to
+238
| // Return silently to avoid revealing whether an OTP exists | ||
| // This maintains security by not leaking information about existing OTPs | ||
| return |
Contributor
There was a problem hiding this comment.
issue: I don't think we are able to directly return here because it is possible that the user is requesting for the OTP to be resent if the email did not reach their inbox. Instead we should be able to resend the email with the same OTP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Breaking Changes
attemptstoattemptsByIpcolumnFeatures:
Improvements:
Bug Fixes:
Before & After Screenshots
BEFORE:
AFTER:
Tests
Deploy Notes
New environment variables:
env var: env var detailsfetch_ssm_parameters.sh)New scripts:
script: script detailsNew dependencies:
dependency: dependency detailsNew dev dependencies:
dependency: dependency detailsNote
Adds per-IP OTP attempt limits backed by a new JSONB column and plumbs client IP through routes/services; also prevents issuing a new OTP while a valid one exists.
otps.attempts_by_ip(JSONB, default{}) via migration and expose asOtp.attemptsByIp.UsersService.verifyOtpusingattemptsByIp; maintain legacyattemptsonly for monitoring.auth.maxNumOtpAttempts; use"unknown"bucket when IP is missing.sendEmailOtpif a non-expired OTP already exists.attemptsandattemptsByIpon OTP issuance (sendEmailOtp,sendSmsOtp).cf-connecting-ipwhen secure, elsereq.ip) inv2/auth.verifyandv2/authenticated/usersOTP verify endpoints.clientIpthroughAuthService.verifyOtp,UsersService.verifyEmailOtp, andverifyMobileOtp.Written by Cursor Bugbot for commit b8c5c1b. This will update automatically on new commits. Configure here.